[PATCH] D22726: [DAGCombine] Match shift amount by value rather than relying on common sub-expressions.

bryant via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 07:48:08 PDT 2016


bryant added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4867
@@ -4860,3 +4866,3 @@
     }
   }
 
----------------
RKSimon wrote:
> It's be great if you can generalise this to work with larger types - i128 for instance. 
that would change the intent of the original code. would it still belong in this patch?


Repository:
  rL LLVM

https://reviews.llvm.org/D22726





More information about the llvm-commits mailing list