[PATCH] D23447: [ELF] - Do not use mergeable sections when LS is used.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 06:14:19 PDT 2016


grimar added a comment.

In https://reviews.llvm.org/D23447#513727, @davide wrote:

> "This change helps for linking FreeBSD kernel."
>
> Can you please elaborate? Have you tried booting and you are able to boot a running kernel with this change, and without you're not able to?


I did not try booting yet, because there are still problems with linking. Without this change linker just crashes in

  void OutputSection<ELFT>::addSection(InputSectionBase<ELFT> *C)
  ..
  auto *S = cast<InputSection<ELFT>>(C); // Here

because we are trying to add MergeableInputSection here.

After that change in combination with other patches that are on review at least lld completes linking. And there are post-link issues still:


https://reviews.llvm.org/D23447





More information about the llvm-commits mailing list