[PATCH] D23437: [LoopInfo] Add a routine for verification by recomputation.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 19:04:53 PDT 2016


chandlerc added inline comments.

================
Comment at: lib/Analysis/LoopInfo.cpp:711-712
@@ -710,1 +710,4 @@
     LI.verify();
+    auto &DT = getAnalysis<DominatorTreeWrapperPass>().getDomTree();
+    LI.verifyByRecomputation(DT);
+  }
----------------
Rather than this, how about putting this into verify (and behind a command line flag if necessary) and computing a fresh DomTree rather than trusting whatever the analysis manager might have?


https://reviews.llvm.org/D23437





More information about the llvm-commits mailing list