[PATCH] D23431: Remove redundant pointer map lookup

[Xinliang David Li via llvm-commits]

It also has an interesting caller -- when basic block is cloned --
updating aliasSet for BB?

David

On Thu, Aug 11, 2016 at 4:44 PM, Daniel Berlin <dberlin at dberlin.org> wrote:
> I'm actually curious why this function goes out of the way to detect when
> both things passed to it are completely irrelevant. Shouldn't the callers be
> doing this?
>
>
> On Thu, Aug 11, 2016, 4:15 PM Xinliang David Li via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> I was thinking that might be reason -- that is why I need a fresh eye
>> to look at it :)
>>
>> thanks,
>>
>> David
>>
>>
>> On Thu, Aug 11, 2016 at 3:52 PM, Michael Kuperstein <mkuper at google.com>
>> wrote:
>> > mkuper requested changes to this revision.
>> > mkuper added a comment.
>> > This revision now requires changes to proceed.
>> >
>> > It looks like this is on purpose:
>> >
>> > https://reviews.llvm.org/rL68047
>> > "getEntryFor() may invalidate DenseMap iterator.
>> > Walking an invalidated iterator is not a good idea."
>> >
>> > I think this is still true, but we should probably add a comment.
>> >
>> >
>> > https://reviews.llvm.org/D23431
>> >
>> >
>> >
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits