[PATCH] D23431: Remove redundant pointer map lookup

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 16:15:30 PDT 2016


I was thinking that might be reason -- that is why I need a fresh eye
to look at it :)

thanks,

David


On Thu, Aug 11, 2016 at 3:52 PM, Michael Kuperstein <mkuper at google.com> wrote:
> mkuper requested changes to this revision.
> mkuper added a comment.
> This revision now requires changes to proceed.
>
> It looks like this is on purpose:
>
> https://reviews.llvm.org/rL68047
> "getEntryFor() may invalidate DenseMap iterator.
> Walking an invalidated iterator is not a good idea."
>
> I think this is still true, but we should probably add a comment.
>
>
> https://reviews.llvm.org/D23431
>
>
>


More information about the llvm-commits mailing list