[PATCH] D23286: AMDGPU/SI: Propose to redefine image load/store intrinsics

Changpeng Fang via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 15:24:28 PDT 2016


cfang added a comment.

In https://reviews.llvm.org/D23286#511206, @nhaehnle wrote:

> I don't know about making vdata (input & output) overloaded. If you do, please at least add a machine instruction verifier that checks the type against dmask.


The data could be types of float or half, so we need to overload the vdata type. Also we need to set https://reviews.llvm.org/D16 bit for vector of half type.

Could you outline what should I do in order to "add a machine instruction verifier that checks the type against dmask". Thanks.


https://reviews.llvm.org/D23286





More information about the llvm-commits mailing list