[PATCH] D23405: [ELF] Do not add start and end symbols in case they are defined in linker script

[Rui Ueyama via llvm-commits]

ruiu added a comment.

Ah, okay, so this change is not really specific to the linker script, but to not define _start/_end symbols if there are already definitions. You want to add a comment about that.


================
Comment at: ELF/Writer.cpp:855
@@ -854,4 +854,3 @@
 template <class ELFT> void Writer<ELFT>::addStartEndSymbols() {
-  auto Define = [&](StringRef Start, StringRef End,
-                    OutputSectionBase<ELFT> *OS) {
+  auto Add = [](StringRef Name, OutputSectionBase<ELFT> *OS, uintX_t Value) {
     if (OS) {
----------------
Looks like this is getting unnecessarily complicated. Two stages of lambdas? Can you simplify this function if you rewrite it?


Repository:
  rL LLVM

https://reviews.llvm.org/D23405