[PATCH] D23402: AMDGPU/SI: Teach SIInstrInfo::FoldImmediate() to fold immediates into copies

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 11:31:12 PDT 2016


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:1225-1226
@@ +1224,4 @@
+    case AMDGPU::V_MOV_B32_e64:
+      if (hasModifiersSet(DefMI, AMDGPU::OpName::src0_modifiers))
+        return false;
+    case AMDGPU::S_MOV_B64:
----------------
I don't think this supports modifiers. I don't think there's any reason to ever use the v_mov_b32 as vop3 so it can probably just be skipped


https://reviews.llvm.org/D23402





More information about the llvm-commits mailing list