[llvm] r278336 - Revert "[AMDGPU] fix failure on printing of non-existing instruction operands."

Valery Pykhtin via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 07:22:05 PDT 2016


Author: vpykhtin
Date: Thu Aug 11 09:22:05 2016
New Revision: 278336

URL: http://llvm.org/viewvc/llvm-project?rev=278336&view=rev
Log:
Revert "[AMDGPU] fix failure on printing of non-existing instruction operands."

This reverts revision 278333, newly added test failed.

Removed:
    llvm/trunk/test/MC/Disassembler/AMDGPU/missing_op.txt
Modified:
    llvm/trunk/lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp

Modified: llvm/trunk/lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp?rev=278336&r1=278335&r2=278336&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp Thu Aug 11 09:22:05 2016
@@ -370,11 +370,6 @@ void AMDGPUInstPrinter::printImmediate64
 void AMDGPUInstPrinter::printOperand(const MCInst *MI, unsigned OpNo,
                                      raw_ostream &O) {
 
-  if (OpNo >= MI->getNumOperands()) {
-    O << "/*Missing OP" << OpNo << "*/";
-    return;
-  }
-
   const MCOperand &Op = MI->getOperand(OpNo);
   if (Op.isReg()) {
     switch (Op.getReg()) {

Removed: llvm/trunk/test/MC/Disassembler/AMDGPU/missing_op.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/Disassembler/AMDGPU/missing_op.txt?rev=278335&view=auto
==============================================================================
--- llvm/trunk/test/MC/Disassembler/AMDGPU/missing_op.txt (original)
+++ llvm/trunk/test/MC/Disassembler/AMDGPU/missing_op.txt (removed)
@@ -1,5 +0,0 @@
-# RUN: llvm-mc -arch=amdgcn -mcpu=fiji -disassemble -show-encoding < %s | FileCheck %s -check-prefix=VI
-
-#TODO: this test will fail when we fix v_interp_p2_f32 signature, remove it then
-#VI: v_interp_p2_f32 16, [/*Missing OP1*/], /*Missing OP2*/, /*Missing OP3*/, /*Missing OP4*/
-0xd4 0x41 0x1d 0xd4




More information about the llvm-commits mailing list