[PATCH] D23384: Use a byte array as an internal buffer of BitVector.

Madhur Amilkanthwar via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 21:25:20 PDT 2016


I agree with David. You mentioned the reasons about design choices and
things which would be allowed with this patch but what about performance?

On Thu, Aug 11, 2016 at 8:36 AM, David Majnemer via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> majnemer added a subscriber: majnemer.
> majnemer added a comment.
>
> Have you actually measured this to be a major improvement? Are there so
> many bits that the old way is a major bottleneck?
> The BitVector is used for the CodeGen and optimizer, I'm not entirely
> convinced it makes sense to modify this generic datastructure so
> drastically for PDBs...
>
>
> https://reviews.llvm.org/D23384
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>



-- 
*Disclaimer: Views, concerns, thoughts, questions, ideas expressed in this
mail are of my own and my employer has no take in it. *
Thank You.
Madhur D. Amilkanthwar
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160811/7b503aec/attachment.html>


More information about the llvm-commits mailing list