[PATCH] D20268: Resolution-based LTO API.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 17:45:11 PDT 2016


mehdi_amini added inline comments.

================
Comment at: lib/LTO/LTO.cpp:318
@@ +317,3 @@
+    RegularLTO.CombinedModule->setTargetTriple(M.getTargetTriple());
+    RegularLTO.CombinedModule->setDataLayout(M.getDataLayout());
+  }
----------------
The ", we typically have callback hooks into the linker defined where the linker could add its own resolved symbols to the combined module" is not clear to me at all (LTOCodeGenerator will never do that AFAIK for example).
(I understand that Gold does something with "commons" at that time, but haven't add time to figure why it is needed) 


https://reviews.llvm.org/D20268





More information about the llvm-commits mailing list