[llvm] r278127 - [Profile] turn off verbose warnings by default

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 17:43:44 PDT 2016


Xinliang David Li via llvm-commits <llvm-commits at lists.llvm.org> writes:
> Author: davidxl
> Date: Tue Aug  9 10:35:28 2016
> New Revision: 278127
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278127&view=rev
> Log:
> [Profile] turn off verbose warnings by default
>
> no prof data for func warning is turned off by default
> due to its high verbosity and minimal usefulness.
>
> Differential Revision: http://reviews.llvm.org/D23295
>
>
>
> Modified:
>     llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
>     llvm/trunk/test/Transforms/PGOProfile/diag_no_funcprofdata.ll
>
> Modified: llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp?rev=278127&r1=278126&r2=278127&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp (original)
> +++ llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp Tue Aug  9 10:35:28 2016
> @@ -124,7 +124,7 @@ static cl::opt<bool> DoComdatRenaming(
>  
>  // Command line option to enable/disable the warning about missing profile
>  // information.
> -static cl::opt<bool> NoPGOWarnMissing("no-pgo-warn-missing", cl::init(false),
> +static cl::opt<bool> NoPGOWarnMissing("no-pgo-warn-missing", cl::init(true),
>                                        cl::Hidden);

Maybe we should reverse the sense and rename the option to
pgo-warn-missing? It takes some thinking to understand what
-no-pgo-warn-missing=false is supposed to mean.

>  
>  // Command line option to enable/disable the warning about a hash mismatch in
>
> Modified: llvm/trunk/test/Transforms/PGOProfile/diag_no_funcprofdata.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/PGOProfile/diag_no_funcprofdata.ll?rev=278127&r1=278126&r2=278127&view=diff
> ==============================================================================
> --- llvm/trunk/test/Transforms/PGOProfile/diag_no_funcprofdata.ll (original)
> +++ llvm/trunk/test/Transforms/PGOProfile/diag_no_funcprofdata.ll Tue Aug  9 10:35:28 2016
> @@ -1,6 +1,6 @@
>  ; RUN: llvm-profdata merge %S/Inputs/diag.proftext -o %t.profdata
> -; RUN: opt < %s -pgo-instr-use -pgo-test-profile-file=%t.profdata -S 2>&1 | FileCheck %s
> -; RUN: opt < %s -passes=pgo-instr-use -pgo-test-profile-file=%t.profdata -S 2>&1 | FileCheck %s
> +; RUN: opt < %s -pgo-instr-use -no-pgo-warn-missing=false -pgo-test-profile-file=%t.profdata -S 2>&1 | FileCheck %s
> +; RUN: opt < %s -passes=pgo-instr-use -no-pgo-warn-missing=false -pgo-test-profile-file=%t.profdata -S 2>&1 | FileCheck %s
>  
>  ; CHECK: No profile data available for function bar
>  
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list