[PATCH] D23377: Add a new method to create SimpleInliner instance and make pre-inliner use this

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 17:11:18 PDT 2016


eraman added inline comments.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:264
@@ +263,3 @@
+    IP.DefaultThreshold = PreInlineThreshold;
+    IP.HotCallSiteThreshold = PreInlineThreshold;
+    // FIXME: The hint threshold has the same value used by the regular inliner.
----------------
davidxl wrote:
> I think it is better to make these two as optional field in InlineParams.
Ok, it make sense. I'm sending a separate NFC patch soon. 


https://reviews.llvm.org/D23377





More information about the llvm-commits mailing list