[PATCH] D22742: Fix `-jobs=<N>` where <N> > 1 and the number of workers is > 1 on macOS.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 11:13:01 PDT 2016


delcypher added a comment.

In https://reviews.llvm.org/D22742#511268, @kubabrecka wrote:

> A bunch of nits.  There really isn’t anything Darwin-specific in the FuzzerUtilDarwin.cpp file, it’s just POSIX code.


It's true that this code isn't really Darwin specific (apart from the forward declared `environ` global). In principle it ought to work on Linux too. I decided to not change how `ExecuteCommand` worked on Linux because it already works correctly there. @kcc how would you feel about using the Darwin implementation of `ExecuteCommand` for Linux too?


https://reviews.llvm.org/D22742





More information about the llvm-commits mailing list