[PATCH] D23286: AMDGPU/SI: Propose to redefine image load/store intrinsics

[Changpeng Fang via llvm-commits]

cfang added a comment.

In https://reviews.llvm.org/D23286#511210, @mareko wrote:

> "unorm" and "da" must be exposed as parameters. They don't change the type, but they change the behavior of the TA hardware block. In all cases, the type is always floating-point.
>
> "r128" doesn't have to be exposed and it's kinda useless. We don't have any use case for it and I think the next-gen hardware (after Polaris) doesn't have it either.


This patch also consider image load and image store. For image store, unorm bit must be 1. I haven't seen any restriction regarding image load.
Are you sure the coordinate type is always float-point? I know for image_sample, it is the case, and not sure image load and image store.


https://reviews.llvm.org/D23286