[compiler-rt] r277975 - [compiler-rt][XRay] Default COMPILER_RT_BUILD_XRAY to ON

[David Blaikie via llvm-commits]

I seem to get a test failure when this is OFF (which it is on my build - I
think the default is only applied when the variable is first seen, so
everyone with it defaulting to OFF have it OFF now unless they blow away
their CMakeCache):

FAIL: XRay-x86_64-linux :: TestCases/Linux/patching-unpatching.cc (30257 of
31128)
 ******************** TEST 'XRay-x86_64-linux ::
TestCases/Linux/patching-unpatching.cc' FAILED ********************
Script:
--
/usr/local/google/home/blaikie/dev/llvm/build/clang/debug/split/notypes/nostandalone/./bin/clang
--driver-mode=g++ -fxray-instrument -m64  -fxray-instrument -std=c++11
/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc
-o
/mnt/fast/dev/llvm/build/clang/debug/split/notypes/nostandalone/projects/compiler-rt/test/xray/X86_64LinuxConfig/TestCases/Linux/Output/patching-unpatching.cc.tmp
XRAY_OPTIONS="patch_premain=false"
 /mnt/fast/dev/llvm/build/clang/debug/split/notypes/nostandalone/projects/compiler-rt/test/xray/X86_64LinuxConfig/TestCases/Linux/Output/patching-unpatching.cc.tmp
2>&1 | FileCheck
/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc
--
Exit Code: 1

Command Output (stderr):
--
/usr/local/google/home/blaikie/install/bin/ld: error: cannot open
/mnt/fast/dev/llvm/build/clang/debug/split/notypes/nostandalone/bin/../lib/clang/4.0.0/lib/linux/libclang_rt.xray-x86_64.a:
No such file or directory
/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function
main: error: undefined reference to '__xray_set_handler'
/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function
main: error: undefined reference to '__xray_patch'
/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function
main: error: undefined reference to '__xray_unpatch'
/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function
main: error: undefined reference to '__xray_patch'
/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function
main: error: undefined reference to '__xray_remove_handler'
/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function
main: error: undefined reference to '__xray_unpatch'
clang-3.5: error: linker command failed with exit code 1 (use -v to see
invocation)

--

Sounds like the test for xray isn't being disabled when the xray feature is
disabled?

On Sun, Aug 7, 2016 at 9:06 PM Dean Michael Berris via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: dberris
> Date: Sun Aug  7 22:58:57 2016
> New Revision: 277975
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277975&view=rev
> Log:
> [compiler-rt][XRay] Default COMPILER_RT_BUILD_XRAY to ON
>
> Modified:
>     compiler-rt/trunk/CMakeLists.txt
>
> Modified: compiler-rt/trunk/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=277975&r1=277974&r2=277975&view=diff
>
> ==============================================================================
> --- compiler-rt/trunk/CMakeLists.txt (original)
> +++ compiler-rt/trunk/CMakeLists.txt Sun Aug  7 22:58:57 2016
> @@ -38,9 +38,7 @@ option(COMPILER_RT_BUILD_BUILTINS "Build
>  mark_as_advanced(COMPILER_RT_BUILD_BUILTINS)
>  option(COMPILER_RT_BUILD_SANITIZERS "Build sanitizers" ON)
>  mark_as_advanced(COMPILER_RT_BUILD_SANITIZERS)
> -
> -# TODO: Flip this to default ON when build bots recognize this new option.
> -option(COMPILER_RT_BUILD_XRAY "Build xray" OFF)
> +option(COMPILER_RT_BUILD_XRAY "Build xray" ON)
>  mark_as_advanced(COMPILER_RT_BUILD_XRAY)
>
>  if (COMPILER_RT_STANDALONE_BUILD)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160810/4c751a80/attachment.html>