[PATCH] D22918: [Loop Vectorizer] Support predication of div/rem

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 10:07:35 PDT 2016


mkuper added a comment.

In https://reviews.llvm.org/D22918#511194, @mssimpso wrote:

> Also, store predication is currently behind a flag that defaults to false (-enable-cond-stores-vec). Since you're reusing the store predication logic, I'm wondering if the mayDivideByZero cases should be under the flag as well. What do you think?
>
> Matt.


The reason enable-cond-stores-vec defaults to false is the lack of cost modeling for predicated stores.
The change to getScalarizationOverhead() is supposed to solve this for divs. But I guess it depends on the real-world performance impact this patch has.


https://reviews.llvm.org/D22918





More information about the llvm-commits mailing list