[llvm] r278178 - [IR] Remove some unused #includes (NFC)

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 02:43:49 PDT 2016


I see a use in PassRegistry.h and lldb's ConstString.cpp. We probably
have to keep it around until we get C++17's std::shared_mutex.

On Wed, Aug 10, 2016 at 1:14 AM, Vedant Kumar via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: vedantk
> Date: Tue Aug  9 18:14:37 2016
> New Revision: 278178
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278178&view=rev
> Log:
> [IR] Remove some unused #includes (NFC)
>
> I needed a reader-writer lock for a downstream project and noticed that
> llvm has one. Function.cpp is the only file in-tree that refers to it.
> To anyone reading this: are you using RWMutex in out-of-tree code? Maybe
> it's not worth keeping around any more...
>
> Since we're not actually using RWMutex *here*, remove the #include (and
> a few other stale headers while we're at it).
>
> Modified:
>     llvm/trunk/lib/IR/Function.cpp
>
> Modified: llvm/trunk/lib/IR/Function.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Function.cpp?rev=278178&r1=278177&r2=278178&view=diff
> ==============================================================================
> --- llvm/trunk/lib/IR/Function.cpp (original)
> +++ llvm/trunk/lib/IR/Function.cpp Tue Aug  9 18:14:37 2016
> @@ -26,10 +26,6 @@
>  #include "llvm/IR/MDBuilder.h"
>  #include "llvm/IR/Metadata.h"
>  #include "llvm/IR/Module.h"
> -#include "llvm/Support/ManagedStatic.h"
> -#include "llvm/Support/RWMutex.h"
> -#include "llvm/Support/StringPool.h"
> -#include "llvm/Support/Threading.h"
>  using namespace llvm;
>
>  // Explicit instantiations of SymbolTableListTraits since some of the methods
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list