[PATCH] D23165: [ELF] - Linkerscript: implement SIZEOF_HEADERS.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 00:23:59 PDT 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:923
@@ -917,1 +922,3 @@
 
+static uint64_t getSizeOfHeaders() {
+  switch (Config->EKind) {
----------------
ruiu wrote:
> This technique is getting ugly as we have more and more functions to interact with the template class. At some point we probably should use a different technique. But for now it is fine (and probably still preferable.)
May be something like I used in first iteration here:
https://reviews.llvm.org/D22759?id=65352 ?


https://reviews.llvm.org/D23165





More information about the llvm-commits mailing list