[PATCH] D22932: Implement llvm-objdump -S and -l

[Saleem Abdulrasool via llvm-commits]

compnerd added inline comments.

================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:381
@@ +380,3 @@
+  DILineInfo OldLineInfo;
+  // Storage for the source
+  const ObjectFile *Obj;
----------------
What exactly do you mean by "storage for the source" here?

================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:398
@@ +397,3 @@
+  virtual void printSourceLine(raw_ostream &OS, uint64_t Address,
+                               StringRef Delimiter = ";;; ");
+};
----------------
Why triple semicolon?  IIRC, the binutils interleaving uses '; '.

================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1304
@@ +1303,3 @@
+        bool Disassembled = DisAsm->getInstruction(
+            Inst, Size, Bytes.slice(Index), SectionAddr + Index, DebugOut,
+            CommentStream);
----------------
Weird, why did this get reflowed?


Repository:
  rL LLVM

https://reviews.llvm.org/D22932