[PATCH] D23194: [LVI] Relax the assertion about LVILatticeVal type in getConstantRange

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 14:50:07 PDT 2016


sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with one nit inline


================
Comment at: lib/Analysis/LazyValueInfo.cpp:1524
@@ +1523,3 @@
+  if (Result.isConstant())
+    // We represent ConstantInt constants as constant ranges but other kinds
+    // of integer constants, i.e. ConstantExpr will be tagged as constants
----------------
I'd sink `Result.isConstant()` into the assert.


https://reviews.llvm.org/D23194





More information about the llvm-commits mailing list