[PATCH] D23321: [sancov] Port sancov -print-coverage-pcs to COFF

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 13:42:01 PDT 2016


kcc added a comment.

code almost LG,
not an expert in lit part. Anyone else?


================
Comment at: tools/sancov/sancov.cc:355
@@ +354,3 @@
+
+      if (Name == "__sanitizer_cov" || Name == "__sanitizer_cov_with_check" ||
+          Name == "__sanitizer_cov_trace_func_enter") {
----------------
don't copy-paste this if statement, move it into a separate function instead. 


https://reviews.llvm.org/D23321





More information about the llvm-commits mailing list