[PATCH] D22726: [DAGCombine] Match shift amount by value rather than relying on common sub-expressions.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 10:57:10 PDT 2016


RKSimon added a comment.

https://reviews.llvm.org/D23007 is now committed to trunk


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4840
@@ -4835,1 +4839,3 @@
+                           DAG.getConstant(~0ULL >> ShAmt, DL, VT));
+      }
     }
----------------
Please generalise this using APInt.


Repository:
  rL LLVM

https://reviews.llvm.org/D22726





More information about the llvm-commits mailing list