[PATCH] D23145: pdbdump: Write a free page map to page 1 or page 2.

[Rui Ueyama via llvm-commits]

ruiu added a comment.

We cannot return an ArrayRef to the internal buffer because of endianness issue. The internal vector is not a byte array, but an array of the word size (32 or 64 bits), so if we return it as a byte array, the result would be different on the BE than on the LE machine. One thing we could do is to return a std::vector as I did in this patch. I'm not sure if this is the right thing to do, though. The other approach would be to use byte instead of word as the internal buffer type. Do you want me to try it?


https://reviews.llvm.org/D23145