[PATCH] D23318: [PATCH] tsan: Remove __pointer_chk_guard at GLIBC_PRIVATE requirement for AArch64

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 09:04:49 PDT 2016


dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

Looks good to me. But I did not read the assembly. Please wait few days for Renato.


================
Comment at: lib/tsan/rtl/tsan_platform_linux.cc:273
@@ +272,3 @@
+
+    // GLIBC mangles the function pointers in jmp_buf (used in {set,long}*jmp
+    // functions) by XORing them with a random guard pointer.  For AArch64 it
----------------
I think this comment belongs to tsan_rtl_aarch64.S.
This file is platform independent, and the things this comment talks about are all in tsan_rtl_aarch64.S.


https://reviews.llvm.org/D23318





More information about the llvm-commits mailing list