[PATCH] D23052: [Inliner] Add a flag to disable manual alloca merging in the Inliner.

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 08:18:27 PDT 2016


mcrosier added a comment.

In https://reviews.llvm.org/D23052#509930, @bmakam wrote:

> In https://reviews.llvm.org/D23052#508976, @mcrosier wrote:
>
> > @bmakam: Would you mind downloading and testing this patch?  Please do full correctness and SPEC200X performance (our head-to-head methodology with train input would be fine).
>
>
> Tested on Kryo. Only these SPEC200X benchmarks had non-noise performance gains(runtime) with this change:
>  | spec2006/soplex:train    | [-2.347%, +3.157%]
>  |spec2006/sphinx3:train   | [+0.469%, +2.124%]
>  |spec2006/xalancbmk:train|[+6.566%, +8.743%] |
>  There were no regressions.


Thanks, Balaram.  No correctness issues, correct?


https://reviews.llvm.org/D23052





More information about the llvm-commits mailing list