[PATCH] D22464: [libunwind][ARM] Fix VFP build attribute for context save/restore code

Oliver Stannard via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 03:17:09 PDT 2016


olista01 added inline comments.

================
Comment at: src/UnwindRegistersRestore.S:374
@@ -371,1 +373,3 @@
+@ vldmia r0, {d0-d15}
+  INST_W 0xec900b20
   JMP(lr)
----------------
compnerd wrote:
> Cant we get away with `.feature`?  IIRC, that doesn't propagate into the build attributes (it is meant for use in such a situation).
Is that an assembler directive? Neither LLVM nor GAS accept it, and I can't find any mention of it in the LLVM source or GAS docs.


https://reviews.llvm.org/D22464





More information about the llvm-commits mailing list