[PATCH] D23256: Teach the analysis manager about inter-analysis dependencies.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 00:11:14 PDT 2016


mehdi_amini added inline comments.

================
Comment at: include/llvm/Analysis/AliasAnalysis.h:894
@@ -895,1 +893,3 @@
+              4>
+      ResultGetters;
 
----------------
silvas wrote:
> mehdi_amini wrote:
> > Wasn't the point of the refactoring with typedef to avoid this kind of diff?
> I didn't eliminate all cases, but I did catch most. This case had a diff hunk that included a proxy change (below) so I kept it in this diff.
> 
> (I had to sort through hundreds of diff hunks so I was literally doing y/n to `git checkout -p` in order to get through them in a reasonable time)
Sure, I just wanted to be sure the patch was really ready before looking more into it.

Thanks for taking the time to reduce it!


https://reviews.llvm.org/D23256





More information about the llvm-commits mailing list