[llvm] r278011 - Revert r2277979.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 14:41:26 PDT 2016


Thanks for reverting this (hopefully the heads-up in IRC saved you some
time). Thankfully this is just an optimization so reverting this isn't a
big deal.

For anybody that feels like chasing this down: I'm guessing this is due to
MSVC getting confused about the SFINAE check in `class
ResultHasInvalidateMethod` in llvm/include/llvm/IR/PassManagerInternal.h
when there are two `run` methods, but that's just a guess.

-- Sean Silva

On Mon, Aug 8, 2016 at 7:51 AM, Nico Weber via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: nico
> Date: Mon Aug  8 09:51:53 2016
> New Revision: 278011
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278011&view=rev
> Log:
> Revert r2277979.
>
> For some reason, MSVC2013's cl.exe crashes with
>   fatal error C1001: An internal error has occurred in the compiler
> with this when compiling e.g. LoopDistribute.cpp.
>
> Modified:
>     llvm/trunk/include/llvm/Analysis/TargetLibraryInfo.h
>
> Modified: llvm/trunk/include/llvm/Analysis/TargetLibraryInfo.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/
> TargetLibraryInfo.h?rev=278011&r1=278010&r2=278011&view=diff
> ============================================================
> ==================
> --- llvm/trunk/include/llvm/Analysis/TargetLibraryInfo.h (original)
> +++ llvm/trunk/include/llvm/Analysis/TargetLibraryInfo.h Mon Aug  8
> 09:51:53 2016
> @@ -273,7 +273,6 @@ public:
>    /// If we try to invalidate this info, just return false. It cannot
> become
>    /// invalid even if the module changes.
>    bool invalidate(Module &, const PreservedAnalyses &) { return false; }
> -  bool invalidate(Function &, const PreservedAnalyses &) { return false; }
>  };
>
>  /// Analysis pass providing the \c TargetLibraryInfo.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160808/6fc70fe8/attachment.html>


More information about the llvm-commits mailing list