[PATCH] D21449: Target independent codesize heuristics for Loop Idiom Recognition

[Chad Rosier via llvm-commits]

mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.

Sorry for the belated response, I've been on vacation for a bit.

LGTM assuming you address my minor nits.


================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:981
@@ +980,3 @@
+                                                   bool IsLoopMemset)
+{
+  const char *IdiomType = IsMemset ? "Memset" : "Memcpy";
----------------
This curly brace should be on the previous line after the left paren.

================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:982
@@ +981,3 @@
+{
+  const char *IdiomType = IsMemset ? "Memset" : "Memcpy";
+
----------------
Can this be a StringRef?


https://reviews.llvm.org/D21449