[PATCH] D23278: [compiler-rt] Allow nm program to be over-ridden for global symbol detection

Francis Ricci via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 11:46:07 PDT 2016


fjricci created this revision.
fjricci added reviewers: samsonov, eugenis, compnerd.
fjricci added a subscriber: llvm-commits.
Herald added subscribers: dberris, kubabrecka.

While cross-compiling, a custom nm program may be required. This will also allow for the
use of llvm-nm if desired.

https://reviews.llvm.org/D23278

Files:
  lib/sanitizer_common/scripts/gen_dynamic_list.py

Index: lib/sanitizer_common/scripts/gen_dynamic_list.py
===================================================================
--- lib/sanitizer_common/scripts/gen_dynamic_list.py
+++ lib/sanitizer_common/scripts/gen_dynamic_list.py
@@ -42,11 +42,12 @@
 
 def get_global_functions(library):
   functions = []
-  nm_proc = subprocess.Popen(['nm', library], stdout=subprocess.PIPE,
+  nm = os.environ.get('NM', 'nm')
+  nm_proc = subprocess.Popen([nm, library], stdout=subprocess.PIPE,
                              stderr=subprocess.PIPE)
   nm_out = nm_proc.communicate()[0].decode().split('\n')
   if nm_proc.returncode != 0:
-    raise subprocess.CalledProcessError(nm_proc.returncode, 'nm')
+    raise subprocess.CalledProcessError(nm_proc.returncode, nm)
   func_symbols = ['T', 'W']
   # On PowerPC, nm prints function descriptors from .data section.
   if os.uname()[4] in ["powerpc", "ppc64"]:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23278.67210.patch
Type: text/x-patch
Size: 898 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160808/bb6a420f/attachment.bin>


More information about the llvm-commits mailing list