[PATCH] D16077: DIBuilder support DI Macro creation

[Adrian Prantl via llvm-commits]

aprantl added a comment.

This doesn't look too bad to me, but maybe I'm not seeing the whole picture: The bulk of the nodes will be DIMacro nodes and if I understand correctly they are leaf nodes and can safely be created non-distinct and shareable immediately. For the DIMacroFiles, we could create them as temporary distinct nodes first — similar to DIBuilder::createReplaceableCompositeType() and then replace them with non-distinct nodes once the lists are finalized.


https://reviews.llvm.org/D16077