[llvm] r277981 - [PM] BasicAA needs to be invalidated since it holds pointers to other stuff.

[Chandler Carruth via llvm-commits]

On Sun, Aug 7, 2016 at 10:45 PM Sean Silva via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: silvas
> Date: Mon Aug  8 00:38:03 2016
> New Revision: 277981
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277981&view=rev
> Log:
> [PM] BasicAA needs to be invalidated since it holds pointers to other
> stuff.
>

While this may be true, I don't think that is a sufficient explanation for
the patch.

I would much rather you actually send this kind of patch out for review and
discussion before landing it.

For example, the alternative approach of passing analysis into the query
path has not been discussed. Nor has a test case been added that
specifically checks this situation.

I'm not saying that this change is necessarily wrong, just trying to point
out what I think would be a better process to follow.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160808/4254a9d6/attachment.html>