[PATCH] D23114: [PM] Introduce a devirtualization iteration layer for the new PM.

[Sean Silva via llvm-commits]

silvas added inline comments.

================
Comment at: include/llvm/Analysis/CGSCCPassManager.h:475
@@ +474,3 @@
+public:
+  explicit DevirtSCCRepeatedPass(PassT Pass, int MaxRepeatitions,
+                                  bool DebugLogging = false)
----------------
Typo: MaxRepeatitions -> MaxRepetitions

================
Comment at: include/llvm/Analysis/CGSCCPassManager.h:557
@@ +556,3 @@
+        // something.
+        if (!F->isIntrinsic()) {
+          Devirt = true;
----------------
Can you just avoid keeping WeakVH's to intrinsics? The langref says you can't take their address. Therefore, a devirtualized call will never be to an intrinsic.
http://llvm.org/docs/LangRef.html#intrinsic-functions


https://reviews.llvm.org/D23114