[PATCH] D23225: [ADCE] Modify data structures to support removing control flow

David Callahan via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 15:25:42 PDT 2016


david2050 added inline comments.

================
Comment at: lib/Transforms/Scalar/ADCE.cpp:146
@@ +145,3 @@
+  BlockInfoVec.resize(NumBlocks);
+  BlockInfo.grow(2 * NumBlocks);
+  auto InfoP = BlockInfoVec.begin();
----------------
mehdi_amini wrote:
> Use `reserve()` instead, unless you have a good reason to use `grow()` here?
I would have sworn I tried to use reserve() on a DenseMap and it did not have it. Must have misunderstood the error message. I will change to use reserve()


https://reviews.llvm.org/D23225





More information about the llvm-commits mailing list