[PATCH] D23225: [ADCE] Modify data structures to support removing control flow

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 15:16:29 PDT 2016


majnemer added inline comments.

================
Comment at: lib/Transforms/Scalar/ADCE.cpp:139
@@ +138,3 @@
+static bool isUnconditionalBranch(TerminatorInst *Term) {
+  auto BR = dyn_cast<BranchInst>(Term);
+  return BR && BR->isUnconditional();
----------------
Prefer `auto *` for pointer types.

================
Comment at: lib/Transforms/Scalar/ADCE.cpp:328
@@ +327,3 @@
+    DeadTerminators.push_back(BB->getTerminator());
+  for (auto I : DeadTerminators)
+    markLive(I);
----------------
Ditto.


https://reviews.llvm.org/D23225





More information about the llvm-commits mailing list