[PATCH] D23225: [ADCE] Modify data structures to support removing control flow

[David Callahan via llvm-commits]

david2050 marked 8 inline comments as done.

================
Comment at: lib/Transforms/Scalar/ADCE.cpp:76
@@ +75,3 @@
+  /// Per basic block information.
+  std::vector<BlockInfoType> BlockInfoVec;
+
----------------
mehdi_amini wrote:
> nadav wrote:
> > Are you using std::vector instead of SmallVector because you are expecting that most function will have a large number of basic blocks? 
> Why do you need this?
> Is it because the iteration ordering over the `BlockInfo` `DenseMap` isn't deterministic? 
> Why can't you always iterate over the function? Will you mutate the ordering in the vector or remove elements?
No, will change.


https://reviews.llvm.org/D23225