[PATCH] D22952: [LoopVectorize] Detect loops in the innermost loop before creating InnerLoopVectorizer

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 22:19:54 PDT 2016


anemet added a comment.

In https://reviews.llvm.org/D22952#506383, @mkuper wrote:

> The LV change LGTM, although if anemet strongly prefers to move this out of the legality check, and into addInnerLoop, I can live with that.


Thanks, Michael.  Yes, that would be my preference.  We need to change the name though to avoid the ambiguity with loop <-> natural loop.  AddLoopWithAcyclicBody?

> I really don't know enough about graph traits to pass judgement on that. One thing I can say is that I have the nagging suspicion LoopBodyTraits should live somewhere closer to LoopInfo, and not in LoopVectorizer.cpp.


This is new to me too but looks pretty interesting so will stare at it more tomorrow.


https://reviews.llvm.org/D22952





More information about the llvm-commits mailing list