[PATCH] D22683: [ELF] Symbol assignment within input section list

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 13:02:27 PDT 2016


evgeny777 added inline comments.

================
Comment at: ELF/LinkerScript.cpp:47
@@ +46,3 @@
+template <class ELFT>
+static inline Symbol *addSymbolToSymtabAux(StringRef Name, uint8_t StOther) {
+  return Symtab<ELFT>::X->addRegular(Name, STB_GLOBAL, StOther);
----------------
rafael wrote:
> You don't need the inline.
Just curious - why?


https://reviews.llvm.org/D22683





More information about the llvm-commits mailing list