[PATCH] D23170: [compiler-rt] Fix memory allocator for dynamic address space

[Kostya Serebryany via llvm-commits]

kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.

LGTM with two nits. 
Thanks!


================
Comment at: lib/sanitizer_common/sanitizer_allocator_primary64.h:99
@@ +98,3 @@
+    if (kUsingConstantSpaceBeg)
+      return (uptr)p & ~(kRegionSize - 1);
+    uptr space_beg = SpaceBeg();
----------------
this code tends to use reinterpret_cast

================
Comment at: lib/sanitizer_common/sanitizer_win.cc:224
@@ -223,3 +223,3 @@
 void *MmapNoAccess(uptr size) {
-  // FIXME: unsupported.
-  return nullptr;
+  void *res = VirtualAlloc(nullptr, size,
+                           MEM_RESERVE, PAGE_NOACCESS);
----------------
do you need two lines here (what will clang-format say?)


https://reviews.llvm.org/D23170