[PATCH] D22683: [ELF] Symbol assignment within input section list

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 09:38:00 PDT 2016


Do you propose to make a patch which would call readProvideOrAssignment
from readSections? AFAIK Rui has removed PROVIDE handler from
readOutputSectionDescription, so that's the only place.

четверг, 4 августа 2016 г. пользователь Rafael Espíndola написал:

> And making sure it has the patch.
>
> Sorry for the noise, somehow my initial replies went just to phab and
> I think it dropped it.
>
> The patch includes a few improvements and is a rebased version of the
> old patch. The rest of the feedback is:
>
> >> This is looking much better.
> >>
> >> This brings back support for PROVIDE both in and out of output
> >> sections, right? Unfortunately this still crashes if I bring
> >> test/ELF/linkerscript/linkerscript-provide-in-section.s back.
> >>
> >> Could you extract readProvideOrAssignment and commit it first?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160804/bacae789/attachment.html>


More information about the llvm-commits mailing list