[PATCH] D22747: [InstCombine] try to fold (select C, (sext A), B) into logical ops

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 01:55:19 PDT 2016


nhaehnle added a comment.

To clarify, I didn't see a case where extending to non-i1 types caused a problem (other than the necessary FoldOpIntoSelect change), but I also didn't see cases where it helped, and in any case I was only looking at the AMDGPU assembly results. I expect that the more common CPU targets could be sensitive to a change there, that's why I kept it conservative.


https://reviews.llvm.org/D22747





More information about the llvm-commits mailing list