[PATCH] D21462: [PM] Make the the new pass manageg support fully generic extra arguments to run methods, both for transform passes and analysis passes.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 00:09:13 PDT 2016


silvas added a comment.

In https://reviews.llvm.org/D21462#505454, @chandlerc wrote:

> Ok, but I don't want to hold up progress waiting on a different design. In my opinion, it doesn't really make sense to pursue both of these directions concurrently in tree because of how much overlap they have and the fact that they seem likely to hold each other up.


The current design of the analysis manager has a fatal bug (no dependency tracking). I'm fixing it. The bug is so fatal that the "new PM" cannot be run on any realistic workload without segfaulting or use-after-free. So the entirety of the "new PM" will be nothing but a toy (essentially dead code) until this is fixed.

Please bear with me as I fix it.

> I understand that you would prefer the design you are pursuing, but unless you have really serious concerns with *this* design that you can express, or there is widespread consensus that we should stop pursuing this design, I'd like to make progress.


I will make that proposal once we have an analysis manager that has basic correctness (which should hopefully be soon).


https://reviews.llvm.org/D21462





More information about the llvm-commits mailing list