[PATCH] D23145: pdbdump: Write a free page map to page 1 or page 2.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 18:06:56 PDT 2016


OK, then let me try to see why we are getting a wrong result for stream 0
first.

On Wed, Aug 3, 2016 at 6:04 PM, Zachary Turner <zturner at google.com> wrote:

> Yea it's ok, but it seems like the same amount of work to do the patch
> either way, but the other way adds more functionality. If you plan to do
> split fpm immediately after this patch I guess I can't complain, but if
> you're planning to work on something else next then we should just do this
> now so it doesn't get neglected
>
>
> On Wed, Aug 3, 2016 at 5:52 PM Rui Ueyama <ruiu at google.com> wrote:
>
>> ruiu added a comment.
>>
>> I guess incremental patches are a preferred way, so in either way, don't
>> you think submitting this is a good idea?
>>
>>
>> https://reviews.llvm.org/D23145
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160803/88950354/attachment.html>


More information about the llvm-commits mailing list