[PATCH] D23146: [ADT] Migrate DepthFirstIterator to use NodeRef

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 17:58:32 PDT 2016


timshen created this revision.
timshen added reviewers: dblaikie, chandlerc.
timshen added a subscriber: llvm-commits.
Herald added a subscriber: mzolotukhin.

Notice that the data layout is changed: instead of using
std::pair<PointerIntPair<NodeType*, 1>, ChildItTy>, now use
std::pair<NodeRef, Optional<ChildItTy>>.

A NFC but worth noticing change is operator==(), since we only compare
an iterator against end(), it's better to put an assert there and make
people noticed when it fails.

https://reviews.llvm.org/D23146

Files:
  include/llvm/ADT/DepthFirstIterator.h
  include/llvm/Analysis/LoopInfo.h
  include/llvm/Analysis/RegionIterator.h
  include/llvm/CodeGen/MachineDominators.h
  include/llvm/CodeGen/MachineLoopInfo.h
  include/llvm/IR/Dominators.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23146.66744.patch
Type: text/x-patch
Size: 13027 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160804/c74a3233/attachment.bin>


More information about the llvm-commits mailing list