[PATCH] D23136: GVN-hoist: enable by default

[Daniel Berlin via llvm-commits]

(you should still wait to see what mehdi, et al say)

On Wed, Aug 3, 2016 at 2:45 PM, Daniel Berlin <dberlin at dberlin.org> wrote:

> I'm fine with this for 4.0. the testcase it was slow on is a testcase
> things like licm take hundreds of seconds on. In fact, gvn hoist is now the
> fastest pass on it that does optimization
>
>
> On Wed, Aug 3, 2016, 2:12 PM Sebastian Pop <sebpop at gmail.com> wrote:
>
>> sebpop created this revision.
>> sebpop added a reviewer: dberlin.
>> sebpop added subscribers: llvm-commits, hiraditya.
>> Herald added a subscriber: mehdi_amini.
>>
>> As we addressed all compilation time problems with GVN-hoist
>> https://llvm.org/bugs/show_bug.cgi?id=28670
>> this patch turns GVN-hoist back by default.
>>
>>
>> https://reviews.llvm.org/D23136
>>
>> Files:
>>   lib/Transforms/IPO/PassManagerBuilder.cpp
>>
>> Index: lib/Transforms/IPO/PassManagerBuilder.cpp
>> ===================================================================
>> --- lib/Transforms/IPO/PassManagerBuilder.cpp
>> +++ lib/Transforms/IPO/PassManagerBuilder.cpp
>> @@ -138,8 +138,8 @@
>>               "(default = 75)"));
>>
>>  static cl::opt<bool> EnableGVNHoist(
>> -    "enable-gvn-hoist", cl::init(false), cl::Hidden,
>> -    cl::desc("Enable the experimental GVN Hoisting pass"));
>> +    "enable-gvn-hoist", cl::init(true), cl::Hidden,
>> +    cl::desc("Enable the experimental GVN Hoisting pass (default =
>> on)"));
>>
>>  PassManagerBuilder::PassManagerBuilder() {
>>      OptLevel = 2;
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160803/965a3644/attachment.html>