[PATCH] D23100: [wasm] Fix FastISel generating NoReg

[Derek Schuff via llvm-commits]

dschuff added inline comments.

================
Comment at: test/CodeGen/WebAssembly/noreg.ll:1
@@ +1,2 @@
+; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -verify-machineinstrs | FileCheck %s
+
----------------
ddcc wrote:
> dschuff wrote:
> > This command line shouldn't result in fast-isel even running, should it?
> Portions of this pass are getting called through e.g. the generic FastISel.cpp:1417 and SelectionDAGISel.cpp:1369 for selecting return instructions.
Hm, I didn't realize that any of this ran when not using fast-isel. In any case we should also add a second RUN line that includes `-fast-isel` to explicitly get as much of fast-isel as possible.

================
Comment at: test/CodeGen/WebAssembly/noreg.ll:3
@@ +2,3 @@
+
+; Test that NoReg is handled correctly by FastISel
+
----------------
This description doesn't really make sense; the fact that NoReg operands are generated is the bug. Really what is happening is that there are parts that cannot be selected by fast-isel but it doesn't properly bail out.


https://reviews.llvm.org/D23100