[lld] r277532 - Support expressions inside FLAGS.

[Rui Ueyama via llvm-commits]

On Wed, Aug 3, 2016 at 1:29 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> >+        // Passing 0 for the value of dot is a bit of a hack. It means
> that
> >+        // we accept expressions like ".|1".
> >+        PhdrCmd.Flags = readExpr()(0);
>
> I think something like D23062 could help here.
> Or like Rui mentioned in comments for D23063, such checks (disallow using
> dot) probably
> should be done at parcing time. It is not the single place where we might
> want
> to restrict using of ".".


I honestly don't care about use of "." here or there. Detecting it doesn't
seems worthwhile.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160803/9c210482/attachment-0001.html>