[PATCH] D23068: LoadStoreVectorizer: Remove TargetBaseAlign. Keep alignment for stack adjustments.

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 14:07:05 PDT 2016


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:444
@@ -443,1 +443,3 @@
+  // rely on the condition below: allow accesses if the size is a multiple of 4.
+  if((VT == MVT::Other) || (VT != MVT::Other && VT.getSizeInBits() > 1024)) {
     return false;
----------------
Space before. Shouldn't need parentheses around the first condition. Should probably check VT.getStoreSize() > 16 (although I'm not sure that will actually matter anywhere)


https://reviews.llvm.org/D23068





More information about the llvm-commits mailing list