[compiler-rt] r276881 - [compiler-rt] Activate interception unittests

Wed Aug 3 12:01:01 PDT 2016

This fixed the warning on my end: https://reviews.llvm.org/D23128

On Tue, Aug 2, 2016 at 7:43 AM, Etienne Bergeron <etienneb at google.com> wrote:
> Sorry, took me a while to figure out why this is generating an error.
> I was looking to the wrong cause.
>
> From this file:
> % \llvm\projects\compiler-rt\lib\interception\tests\CMakeLists.txt
>
> There is that condition:
>   if(COMPILER_RT_CAN_EXECUTE_TESTS AND NOT ANDROID AND NOT APPLE)
>
> Which mean the unittest are not activated, and it's causing an empty set of
> test to run.
> I do not have access to any Apple computer. I'll sync with rnk@ to fix this.
>
>
> On Mon, Aug 1, 2016 at 4:51 PM, Etienne Bergeron <etienneb at google.com>
> wrote:
>>
>> Yes, I can take a look.
>>
>> There are only unittests to run, and Windows only.
>> There are no lit tests for interception.
>>
>> On Mon, Aug 1, 2016 at 4:46 PM, Bruno Cardoso Lopes
>> <bruno.cardoso at gmail.com> wrote:
>>>
>>> Hi Etienne,
>>>
>>> This change trigger a warning in some of our public bots (and also
>>> internally),
>>> http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/8686:
>>>
>>> lit.py:
>>> /Users/buildslave/jenkins/sharedspace/clang-R_master at 2/llvm/utils/lit/lit/discovery.py:224:
>>> warning: input
>>> '/Users/buildslave/jenkins/sharedspace/clang-R_master at 2/clang-build/Build/tools/clang/runtime/compiler-rt-bins/test/interception/Unit'
>>> contained no tests
>>>
>>> I don't see any real tests on the directory, but looks like it's
>>> setting up something from interception/Unit/lit.site.cfg.in, is that
>>> right? Can you please take a look into silence this warning?
>>>
>>> Thanks,
>>>
>>> On Wed, Jul 27, 2016 at 8:29 AM, Etienne Bergeron via llvm-commits
>>> <llvm-commits at lists.llvm.org> wrote:
>>> > Author: etienneb
>>> > Date: Wed Jul 27 10:29:49 2016
>>> > New Revision: 276881
>>> >
>>> > URL: http://llvm.org/viewvc/llvm-project?rev=276881&view=rev
>>> > Log:
>>> > [compiler-rt] Activate interception unittests
>>> >
>>> > Summary:
>>> > The unittests recently added were not running when executing
>>> > 'check-all'.
>>> > Tests are stable on every archictetures and we can now turn them on.
>>> >
>>> > Reviewers: rnk
>>> >
>>> > Subscribers: llvm-commits, wang0109, chrisha
>>> >
>>> > Differential Revision: https://reviews.llvm.org/D22695
>>> >
>>> > Added:
>>> >     compiler-rt/trunk/test/interception/CMakeLists.txt
>>> >     compiler-rt/trunk/test/interception/Unit/
>>> >     compiler-rt/trunk/test/interception/Unit/lit.site.cfg.in
>>> > Modified:
>>> >     compiler-rt/trunk/test/CMakeLists.txt
>>> >
>>> > Modified: compiler-rt/trunk/test/CMakeLists.txt
>>> > URL:
>>> > http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/CMakeLists.txt?rev=276881&r1=276880&r2=276881&view=diff
>>> >
>>> > ==============================================================================
>>> > --- compiler-rt/trunk/test/CMakeLists.txt (original)
>>> > +++ compiler-rt/trunk/test/CMakeLists.txt Wed Jul 27 10:29:49 2016
>>> > @@ -45,6 +45,9 @@ if(COMPILER_RT_CAN_EXECUTE_TESTS)
>>> >    if(COMPILER_RT_HAS_DFSAN)
>>> >      add_subdirectory(dfsan)
>>> >    endif()
>>> > +  if (COMPILER_RT_HAS_INTERCEPTION)
>>> > +    add_subdirectory(interception)
>>> > +  endif()
>>> >    if(COMPILER_RT_HAS_LSAN)
>>> >      add_subdirectory(lsan)
>>> >    endif()
>>> >
>>> > Added: compiler-rt/trunk/test/interception/CMakeLists.txt
>>> > URL:
>>> > http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/interception/CMakeLists.txt?rev=276881&view=auto
>>> >
>>> > ==============================================================================
>>> > --- compiler-rt/trunk/test/interception/CMakeLists.txt (added)
>>> > +++ compiler-rt/trunk/test/interception/CMakeLists.txt Wed Jul 27
>>> > 10:29:49 2016
>>> > @@ -0,0 +1,16 @@
>>> > +set(INTERCEPTION_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
>>> > +set(INTERCEPTION_TESTSUITES)
>>> > +
>>> > +# Unit tests.
>>> > +if(COMPILER_RT_INCLUDE_TESTS)
>>> > +  configure_lit_site_cfg(
>>> > +    ${CMAKE_CURRENT_SOURCE_DIR}/Unit/lit.site.cfg.in
>>> > +    ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg)
>>> > +  list(APPEND INTERCEPTION_TESTSUITES
>>> > ${CMAKE_CURRENT_BINARY_DIR}/Unit)
>>> > +  list(APPEND INTERCEPTION_TEST_DEPS InterceptionUnitTests)
>>> > +endif()
>>> > +
>>> > +add_lit_testsuite(check-interception "Running the Interception tests"
>>> > +  ${INTERCEPTION_TESTSUITES}
>>> > +  DEPENDS ${INTERCEPTION_TEST_DEPS})
>>> > +set_target_properties(check-interception PROPERTIES FOLDER
>>> > "Compiler-RT Misc")
>>> >
>>> > Added: compiler-rt/trunk/test/interception/Unit/lit.site.cfg.in
>>> > URL:
>>> > http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/interception/Unit/lit.site.cfg.in?rev=276881&view=auto
>>> >
>>> > ==============================================================================
>>> > --- compiler-rt/trunk/test/interception/Unit/lit.site.cfg.in (added)
>>> > +++ compiler-rt/trunk/test/interception/Unit/lit.site.cfg.in Wed Jul 27
>>> > 10:29:49 2016
>>> > @@ -0,0 +1,14 @@
>>> > + at LIT_SITE_CFG_IN_HEADER@
>>> > +
>>> > +# Load common config for all compiler-rt unit tests.
>>> > +lit_config.load_config(config,
>>> > "@COMPILER_RT_BINARY_DIR@/unittests/lit.common.unit.configured")
>>> > +
>>> > +# Setup config name.
>>> > +config.name = 'Interception-Unit'
>>> > +
>>> > +# Setup test source and exec root. For unit tests, we define
>>> > +# it as build directory with interception tests.
>>> > +# FIXME: De-hardcode this path.
>>> > +config.test_exec_root = os.path.join("@COMPILER_RT_BINARY_DIR@",
>>> > "lib",
>>> > +                                     "interception", "tests")
>>> > +config.test_source_root = config.test_exec_root
>>> >
>>> >
>>> > _______________________________________________
>>> > llvm-commits mailing list
>>> > llvm-commits at lists.llvm.org
>>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>>
>>>
>>> --
>>> Bruno Cardoso Lopes
>>> http://www.brunocardoso.cc
>>
>>
>>
>>
>> --
>> Etienne Bergeron
>> Chrome
>
>
>
>
> --
> Etienne Bergeron
> Chrome


-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc